Skip to content

askrene: askrene-remove-channel-update#9040

Open
Lagrang3 wants to merge 1 commit intoElementsProject:masterfrom
Lagrang3:askrene-remove-update
Open

askrene: askrene-remove-channel-update#9040
Lagrang3 wants to merge 1 commit intoElementsProject:masterfrom
Lagrang3:askrene-remove-update

Conversation

@Lagrang3
Copy link
Copy Markdown
Collaborator

@Lagrang3 Lagrang3 commented Apr 9, 2026

Add a new RPC askrene-remove-channel-update to remove channel_update entries from layers.

@Lagrang3 Lagrang3 requested a review from cdecker as a code owner April 9, 2026 08:59
@Lagrang3 Lagrang3 requested a review from rustyrussell April 9, 2026 09:00
@Lagrang3 Lagrang3 added this to the 26.06 milestone Apr 9, 2026
@Lagrang3 Lagrang3 added the feature Aimed at improving the existing functionality or a new feature that provides additional value label Apr 9, 2026
@cdecker
Copy link
Copy Markdown
Member

cdecker commented Apr 9, 2026

Is the intention here to undo an update that was applied or to make that direction unusable? The implementation does the latter, though you can just feed in any prior update and re-enable it with those params again.

@daywalker90
Copy link
Copy Markdown
Collaborator

I assume this is in line with the other askrene commands and we want it in cln-grpc etc.:

If so, please:

  1. add AskRene-Remove-Channel-Update to grpc_method_names in contrib/msggen/msggen/utils/utils.py
  2. run uv run make gen.

If that doesn't generate anything you should try touch ‎doc/schemas/askrene-remove-channel-update.json first and then 2. again.

@Lagrang3
Copy link
Copy Markdown
Collaborator Author

Lagrang3 commented Apr 10, 2026

Is the intention here to undo an update that was applied or to make that direction unusable? The implementation does the latter, though you can just feed in any prior update and re-enable it with those params again.

These entries override the channel properties we get from gossip.
I just want to be able to remove the entry from the list when it is no longer needed.

Changelog-Added: askrene: askrene-remove-channel-update, a new RPC to remove channel_update entries from layers.

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
@Lagrang3 Lagrang3 force-pushed the askrene-remove-update branch from 110a637 to ba6019a Compare April 10, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Aimed at improving the existing functionality or a new feature that provides additional value

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants